continuous logging added to multimeter #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you please get rid of the "read" and "reset" button and implement it in a way that it always shows the data input, if any. In a multimeter device there is no such thing as a read or input button. As soon as the user connects the device to do measurements it shows the output. Same should happen here. Please implement it in the same way like an actual multimeter. |
Member
Author
|
@mariobehling on it. :) |
neel1998
force-pushed
the
multimeter_continuous_log
branch
from
8eec288 to
da84fa6
Compare
Member
Author
|
@mariobehling i have made the changes you suggested. Please have a look |
ho-dor
suggested changes
Jun 2, 2019
ho-dor
left a comment
ho-dor
left a comment
There was a problem hiding this comment.
Same issue in multiple places , hard coded dimen values.
| android:layout_marginEnd="@dimen/multimeter_constraint_1" | ||
| android:layout_marginRight="@dimen/multimeter_constraint_1" | ||
| android:layout_marginStart="@dimen/multimeter_constraint_1" | ||
| android:layout_marginBottom="16dp" |
| android:layout_marginEnd="@dimen/multimeter_constraint_2" | ||
| android:layout_marginRight="@dimen/multimeter_constraint_2" | ||
| android:layout_marginStart="@dimen/multimeter_constraint_2" | ||
| android:layout_marginBottom="5dp" |
| android:layout_marginEnd="@dimen/multimeter_constraint_1" | ||
| android:layout_marginRight="@dimen/multimeter_constraint_1" | ||
| android:layout_marginStart="@dimen/multimeter_constraint_1" | ||
| android:layout_marginBottom="8dp" |
| android:layout_marginBottom="8dp" | ||
| android:gravity="center" | ||
| android:text="@string/multimeter_measure" | ||
| android:textSize="14sp" |
| android:layout_height="0dp" | ||
| android:layout_marginBottom="8dp" | ||
| android:layout_marginTop="8dp" | ||
| android:layout_marginBottom="8dp" |
| android:layout_marginBottom="8dp" | ||
| android:layout_marginTop="5dp" | ||
| app:layout_constraintBottom_toTopOf="@+id/reset" | ||
| android:layout_marginBottom="8dp" |
| android:layout_marginEnd="@dimen/multimeter_constraint_1" | ||
| android:layout_marginRight="@dimen/multimeter_constraint_1" | ||
| android:layout_marginStart="@dimen/multimeter_constraint_1" | ||
| android:layout_marginBottom="24dp" |
| android:layout_marginEnd="@dimen/multimeter_left_box_endmargin" | ||
| android:layout_marginRight="@dimen/multimeter_left_box_endmargin" | ||
| android:layout_marginStart="@dimen/multimeter_layout_margin_2" | ||
| android:layout_marginBottom="8dp" |
adityastic
approved these changes
Jun 2, 2019
Contributor
adityastic
left a comment
adityastic
left a comment
There was a problem hiding this comment.
Make changes by ho-dor. Everything else seems fine
Member
Author
|
@ho-dor @CloudyPadmal I removed the hard coded dimensions. Please review |
ho-dor
approved these changes
Jun 3, 2019
CloudyPadmal
approved these changes
Jun 3, 2019
neel1998
added a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
* continuous logging added to multimeter * hardcoded dimensions removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1762 #1373
Changes: User can now continuously log data in multimeter and can set time interval in configuration settings. Reset / Read buttons removed
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
multimeter.zip
@CloudyPadmal @ho-dor please review