Hard coded,redundant code removed #1808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Jun 19, 2019
| <LinearLayout | ||
| android:id="@+id/servo_timeline_controls" | ||
| android:layout_width="10dp" | ||
| android:layout_width="@dimen/robotic_arm_margin_10" |
Collaborator
There was a problem hiding this comment.
Let's not put value at the end
| <dimen name="robotic_arm_margin_7">7dp</dimen> | ||
| <dimen name="robotic_arm_margin_10">10dp</dimen> | ||
| <dimen name="robotic_arm_height">25dp</dimen> | ||
| <dimen name="servo_image_width">20dp</dimen> |
Collaborator
There was a problem hiding this comment.
Place these close to their respective counterparts. May be you can give a clean up to the whole strings file keeping variables related to a single component close
CloudyPadmal
added
the
Status: Review Required
neel1998
approved these changes
Jun 21, 2019
CloudyPadmal
approved these changes
Jun 21, 2019
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1807
Changes:Removed hard coded values and redundant attributes in layouts
Screenshot/s for the changes:N/A
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
redundant.zip