Accelerometer code refactored #1813
Conversation
|
Codacy |
neel1998
added
the
Status: Review Required
|
Not crashing in my device @neel1998 . Can you please send a gif or log of the crash |
|
|
|
Why is it showing no data fetched when you played the log. I am trying from the apk..Is the apk in the PR the latest one?.. please check |
|
Also make screen taps visible when you make a gif...It's hard to understand which buttons you are pressing from this gif |
Ya I found that error now . I will update and send the apk |
|
@neel1998 it would be helpful if you can submit the crash log |
|
@neel1998 does your device have the gyroscope sensor ? If yes, can you send a gif of logged data. |
|
@neel1998 @CloudyPadmal please check. |
|
@neel1998 the issue is actually deeper than I thought . I am going to try and make a PR tomorrow |
|
@ho-dor cool. No problem. |
|
@neel1998 @CloudyPadmal I have updated the apk. |
|
@ho-dor pause button while playing back is not working. Even if i click on play the graphs continue to move forward |
ho-dor
force-pushed
the
improve
branch
2 times, most recently
from
accb72b to
24cb870
Compare
|
@neel1998 updated the apk . Check |
|
@neel1998 please review this . Its been pending |
|
Tested the provided apk. It's not crashing though 🤔 |
|
Yeah, it has been resolved, the logged data doesn't start on it's own either and pauses when it should. I think this good to go. |
|
@CloudyPadmal It's not suppose to crash after the fix. So i think the PR is good to go |
CloudyPadmal
removed
the
Status: Review Required
3 participants
Fixes #1812
Changes:Accelerometer code changed more like gyroscope
Screenshot/s for the changes: N/A
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
refactor.zip