Skip to content

Conversation

@ho-dor
Copy link

@ho-dor ho-dor commented Jun 24, 2019

Fixes #1394

Changes: added images for fdroid listing in fastlane/metadata/android/en-us/images/ folder.

Screenshot/s for the changes:N/A

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:N/A

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ho-dor
Copy link
Author

ho-dor commented Jun 25, 2019

@CloudyPadmal done

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That was a very good response to requested changes :) 💯

@CloudyPadmal CloudyPadmal requested a review from neel1998 June 25, 2019 13:24
@CloudyPadmal CloudyPadmal added the Status: Review Required Requested reviews from peers and maintainers label Jun 25, 2019
@CloudyPadmal CloudyPadmal merged commit 6151289 into fossasia:development Jun 25, 2019
@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Jun 25, 2019
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve F-Droid listing

3 participants