Skip to content

Conversation

@neel1998
Copy link
Member

Fixes #1817

Changes: Fourier Transform added for built in mic

Screenshot/s for the changes:
20190625_221513

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

fft_mic.zip

@CloudyPadmal @mariobehling @ho-dor @cweitat have a look

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Complex[] yComplex = new Complex[n];
for (int j = 0; j < n; j++) {
float audioValue = (float) map(buffer[j], -32768, 32767, -3, 3);
Log.d("mic", audioValue + "");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. sorry i forgot to remove debugging statement

@CloudyPadmal CloudyPadmal requested a review from ho-dor June 25, 2019 18:27
@CloudyPadmal CloudyPadmal added the Status: Review Required Requested reviews from peers and maintainers label Jun 25, 2019
@cweitat cweitat merged commit 5a50323 into fossasia:development Jun 25, 2019
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
Fix fossasia#1817 fourier transform for built in mic input working fine
@neel1998 neel1998 deleted the fft_mic branch August 27, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Required Requested reviews from peers and maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Fourier Transform feature for CH3 and Built In MIC

3 participants