fix: unstable oscilloscope bug fixed #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
changed the title
CloudyPadmal
approved these changes
Aug 13, 2019
Collaborator
|
@woshikie could you please test the apk when you get time? |
Member
Author
|
@CloudyPadmal thanks for the review 😇 |
CloudyPadmal
added
Fix
makoteq
pushed a commit
to makoteq/pslab-android
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1518
Changes: unstable oscilloscope bug fixed
Screenshot/s for the changes:
**Before:
**After:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
osc.zip
@CloudyPadmal @cweitat have a look. Feels good when after debugging a huge code just couple of line changes do the miracle. 😂