Skip to content

Conversation

@neel1998
Copy link
Member

@neel1998 neel1998 commented Aug 21, 2019

Fixes #1947

Changes:

  1. Radio buttons for mic added
  2. Margins between components added
  3. Some text boxes aligned
  4. Left control panel width reduces

Screenshot/s for the changes:

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: WIP
osc.zip

@neel1998 neel1998 added the In Progress Developer is working on the problem label Aug 21, 2019
@neel1998 neel1998 self-assigned this Aug 21, 2019
@mariobehling
Copy link
Member

Please always provide a screenshot.

@neel1998
Copy link
Member Author

It is still WIP. .That's why I haven't added a screenshot. Will ad when I finalize the PR

@neel1998 neel1998 force-pushed the osc_main_ui_change branch from 71bde3b to 99ed3e5 Compare August 22, 2019 20:07
@neel1998 neel1998 added Enhancement Improvement to an existing feature and removed In Progress Developer is working on the problem labels Aug 22, 2019
@CloudyPadmal
Copy link
Collaborator

Make the bottom line of CH1, CH2 channel panel align with the right side panel bottom line. Now the right side panel bottom line is a bit lowered than the channel panel

@adityastic
Copy link
Contributor

Can we not give this interface a modern look? @CloudyPadmal

@CloudyPadmal
Copy link
Collaborator

@adityastic we can. Still the design need to have the look of a real device. Do you have any idea?

@neel1998 neel1998 force-pushed the osc_main_ui_change branch from 99ed3e5 to cd6b0f7 Compare August 23, 2019 11:32
@neel1998
Copy link
Member Author

@CloudyPadmal I have made the requested changes

@neel1998 neel1998 force-pushed the osc_main_ui_change branch from cd6b0f7 to f3c3cb2 Compare August 23, 2019 13:50
@neel1998 neel1998 force-pushed the osc_main_ui_change branch from f3c3cb2 to 6c71bd2 Compare August 25, 2019 08:29
@neel1998
Copy link
Member Author

@mariobehling I have made the changes we discussed in the last meet. Please review and merge this

@adityastic
Copy link
Contributor

@CloudyPadmal yes sir, I do have ideas. I shall soon provide a demo of what I intend to propose on the gitter channel 🥰

@CloudyPadmal
Copy link
Collaborator

@CloudyPadmal yes sir, I do have ideas. I shall soon provide a demo of what I intend to propose on the gitter channel 🥰

Nice. Looking forward to ..

@neel1998
Copy link
Member Author

@CloudyPadmal can we merge this for now. And once Aditya proposes new layout we can make changes accordingly.

@neel1998
Copy link
Member Author

@mariobehling can we merge this?

@CloudyPadmal CloudyPadmal merged commit d23f44e into fossasia:development Aug 27, 2019
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oscilloscope main screen UI changes

4 participants