-
Notifications
You must be signed in to change notification settings - Fork 814
fix: osc main screen ui changes #1955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: osc main screen ui changes #1955
Conversation
|
Please always provide a screenshot. |
|
It is still WIP. .That's why I haven't added a screenshot. Will ad when I finalize the PR |
71bde3b to
99ed3e5
Compare
|
Make the bottom line of CH1, CH2 channel panel align with the right side panel bottom line. Now the right side panel bottom line is a bit lowered than the channel panel |
|
Can we not give this interface a modern look? @CloudyPadmal |
|
@adityastic we can. Still the design need to have the look of a real device. Do you have any idea? |
99ed3e5 to
cd6b0f7
Compare
|
@CloudyPadmal I have made the requested changes |
app/src/main/res/layout-sw600dp/fragment_channel_parameters.xml
Outdated
Show resolved
Hide resolved
cd6b0f7 to
f3c3cb2
Compare
f3c3cb2 to
6c71bd2
Compare
|
@mariobehling I have made the changes we discussed in the last meet. Please review and merge this |
|
@CloudyPadmal yes sir, I do have ideas. I shall soon provide a demo of what I intend to propose on the gitter channel 🥰 |
Nice. Looking forward to .. |
|
@CloudyPadmal can we merge this for now. And once Aditya proposes new layout we can make changes accordingly. |
|
@mariobehling can we merge this? |
Fixes #1947
Changes:
Screenshot/s for the changes:

Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: WIP
osc.zip