Fixes #1999 Replaced Toast Messages with Snackbar messages #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please don't open and close PR for same issue multiple times. Make changes to the same PR. Thank you. |
Contributor
Author
|
Sorry for that! Will be careful hence. Thanks :) |
abhishekbisht1429
force-pushed
the
development
branch
from
405487b to
023fe7d
Compare
abhishekbisht1429
force-pushed
the
development
branch
from
023fe7d to
2685c42
Compare
Contributor
Author
|
Replaced Toast with Snackbar, please have a look and suggest changes if any. |
Contributor
Author
|
Hi people! Could someone please tell what should i do with this pull request, does it need any changes? I am new to open source contributions and the PSLab project so I am not aware of the usual duration that it takes for a pull request to be reviewed and approved/rejected. |
CloudyPadmal
approved these changes
Nov 24, 2019
adityastic
approved these changes
Nov 25, 2019
neel1998
approved these changes
Nov 26, 2019
Member
neel1998
left a comment
neel1998
left a comment
There was a problem hiding this comment.
Looks good. Nice work. Thanks
Contributor
Author
|
Thanks and also you are welcome! @neel1998 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1999
Changes:
Replaced all the occurrence of
ToastwithSnackbar. The classio.pslab.others.CustomSnackbarwas used to make Snackbars.Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
issue1999fix.zip