Added strings.xml in Arabic #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityastic
approved these changes
Dec 22, 2019
Contributor
Author
|
@nikit19 Please review and merge |
Contributor
Author
|
@adityastic Please review this :) |
Contributor
|
@CloudyPadmal please review |
Contributor
Author
|
Just 24 hrs left for the task :( @CloudyPadmal @adityastic @nikit19 |
Contributor
|
@IzhanAli don't worry I'll extend it for you |
Contributor
Author
|
@adityastic Thanks |
Contributor
Author
|
It's taking longer than expected :( |
Contributor
|
@IzhanAli It's the end of year, people usually arnt working at this time of the year. Please be patient and wait till 5th Jan |
Contributor
|
do you have a screenshot or GIF to show how it looks? |
CloudyPadmal
requested changes
Jan 17, 2020
Collaborator
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
APKs and Screenshots?
CloudyPadmal
added
the
Status: Review Required
mariobehling
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2037
Changes: Translated strings.xml into Arabic Language
Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a
*.gifcontaining a demonstration]Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: It doesn't need