fix #2020: Alignment of "Time Interval" dropdown #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Where is the colour change that you mentioned in the issue? Was it done? But don't just just the colour without furthur discussion as this affects the entire app |
Member
Author
|
@cweitat I had made the alignment of the dropdowns properly and didn't changed any color or theme for now as I don't think it is required. |
cweitat
approved these changes
Jan 5, 2020
CloudyPadmal
requested changes
Jan 17, 2020
Collaborator
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
Align them to right side and fill the width with spinner content
Member
Author
|
okay @CloudyPadmal will make the changes |
Member
Author
|
|
Member
Author
|
@CloudyPadmal please check it. |
CloudyPadmal
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix First steps for issues #2020: Alignment of "Time Interval" dropdown
Changes: Made the Alignment of Time Interval and instrument dropdown properly
Screenshot/s for the changes
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]