Fixes: PSLabSensor Activity decoupled from fragments #2110
Conversation
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
@VIKAS9899 thank you for the pull request. Seems good. Can you build the APK file and upload here so that we can test it? Also I have requested some code refactoring changes. Thanks again.
| fragment=getSupportFragmentManager() | ||
| .findFragmentByTag(getSensorName()); | ||
|
|
||
| if (fragment instanceof OperationCallback){ | ||
| ((OperationCallback) fragment).playData(); |
There was a problem hiding this comment.
Reformat the code here. You can use automatic option in Android studio. It will add missing spaces and indents.
| fragment=getSupportFragmentManager() | ||
| .findFragmentByTag(getSensorName()); | ||
|
|
||
| if (fragment instanceof OperationCallback){ |
There was a problem hiding this comment.
Similar reformatting here
| fragment=getSupportFragmentManager() | ||
| .findFragmentByTag(getSensorName()); | ||
|
|
||
| if (fragment instanceof OperationCallback){ | ||
| ((OperationCallback) fragment).saveGraph(); |
@CloudyPadmal I have refracted the code. Please find the APK below https://drive.google.com/file/d/1H9k2Cs57xeW-3suS-MlLtiSWBeZkuOlJ/view?usp=sharing |
3 participants
Fixes #2108
Changes: PSLabSensorActivity will interact with OperationCallback for operation not any specific fragments by doing this we can eliminate coupling & reduce boilerplate code.