Fixes #2070 Add missing elements to Oscilloscope layout for tablets #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Travis-CI does not seem to return any status which I think is a prerequisite to add reviewers. Please let me know if there is anything I can/must do to advance this PR. |
Updated strings.xml
CloudyPadmal
requested changes
Jun 20, 2020
CloudyPadmal
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2070
Changes: The layout for phones and tablets was out of sync. The tablet version was missing several elements which were present in the phone version and which the Activity relied on. I added the missing elements to the layout for tablet devices. I have added values to dimens.xml for tablet devices.
Screenshot/s for the changes:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
bugfix2070.zip