Skip to content

fix generate config file layout and modify item checkbox margin. #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2020
Merged

fix generate config file layout and modify item checkbox margin. #2124

merged 2 commits into from
Oct 2, 2020

Conversation

@CodeWithSouma
Copy link
Member

@CodeWithSouma CodeWithSouma commented Aug 30, 2020

Fix Generate config file layout

  • Add weight to devide linear layout horizontal and vertical
  • Add font size of textView
  • Fix margin checkBox Card

CloudyPadmal
CloudyPadmal requested changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use dimens.xml file without hard-coding values in resource files.

@CodeWithSouma
Copy link
Member Author

CodeWithSouma commented Aug 31, 2020 •
edited
Loading

@CloudyPadmal @mariobehling

fix hard-coding issue

Remove hard-coding value from activity_create_config.xml and put into dimens.xml

@CodeWithSouma
Copy link
Member Author

CodeWithSouma commented Sep 9, 2020

Use dimens.xml file without hard-coding values in resource files.

Sir please checkout i solved this issue

@CloudyPadmal CloudyPadmal added the Enhancement Improvement to an existing feature label Oct 2, 2020
@CloudyPadmal CloudyPadmal merged commit db84259 into fossasia:development Oct 2, 2020
@CodeWithSouma CodeWithSouma deleted the newbranch branch October 17, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees

@CodeWithSouma CodeWithSouma

Labels

Enhancement Improvement to an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeWithSouma @CloudyPadmal