Skip to content

Faq error #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Faq error #2127

wants to merge 5 commits into from

Conversation

@CodeWithSouma
Copy link
Member

@CodeWithSouma CodeWithSouma commented Sep 2, 2020

Fix Faq expandable listview error #2126

  • use expandable listView
  • create a custom adapter
  • set that adapter in expandable listView

CloudyPadmal
CloudyPadmal requested changes Sep 9, 2020
View reviewed changes
@CodeWithSouma CodeWithSouma mentioned this pull request Sep 13, 2020
Closed
CloudyPadmal
CloudyPadmal requested changes Oct 2, 2020
View reviewed changes
@CloudyPadmal CloudyPadmal added the Question Needs more information label Oct 2, 2020
CloudyPadmal
CloudyPadmal reviewed Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what has changed in this PR to address the parent issue. What I can see is, the String arrays were replaced by Lists and HashMaps and rearranged the code here and there. @CodeWithSouma can you elaborate more on what was the bug and what was the solution? Thanks..

@CodeWithSouma
Copy link
Member Author

CodeWithSouma commented Oct 12, 2020 •
edited
Loading

I wonder what has changed in this PR to address the parent issue. What I can see is, the String arrays were replaced by Lists and HashMaps and rearranged the code here and there. @CodeWithSouma can you elaborate more on what was the bug and what was the solution? Thanks..

line no 120 Html.FROM_HTML_MODE_COMPACT it should not use it causes the app crash. I preferred hashMap in expandable listView so i also refactor the code.If you dont like this i can change it and fix the bug.

@CloudyPadmal
Copy link
Collaborator

CloudyPadmal commented Oct 12, 2020

I wonder what has changed in this PR to address the parent issue. What I can see is, the String arrays were replaced by Lists and HashMaps and rearranged the code here and there. @CodeWithSouma can you elaborate more on what was the bug and what was the solution? Thanks..

line no 120 Html.FROM_HTML_MODE_COMPACT it should not use it causes the app crash. I preferred hashMap in expandable listView so i also refactor the code.If you dont like this i can change it and fix the bug.

Yes. Let's modify only the parts related to the crash. If you want to change the code base, we can open an issue and work it on a separate PR.

@CodeWithSouma
Copy link
Member Author

CodeWithSouma commented Oct 12, 2020

Sir i close this PR and please check out this PR #2138 . I fix this issue as you want please check out and merge this PR #2138

@CodeWithSouma CodeWithSouma deleted the faq-error-fix branch October 17, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

Assignees

@CodeWithSouma CodeWithSouma

Labels

Question Needs more information

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeWithSouma @CloudyPadmal