Main Tiles Resolved #2132
Merged
Main Tiles Resolved #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@low012 can you have the look at this apk and tell me is it Working fine on your devices |
Contributor
Thumbs up! It is working for me now! |
CloudyPadmal
approved these changes
Oct 3, 2020
Collaborator
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
Thank you for the PR! 👍 Next time onwards, squash the commits into one when finalizing the PR.
nileshteji
added a commit
to nileshteji/pslab-android
that referenced
this pull request
Oct 3, 2020
Main Screen Tiles Fixed (fossasia#2132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2116
Changes:
Removal of AsyncTask because it does not behave well with screen orientation changes. Instead Created a simple method that will do the task. Not used Loopers for it because of the reason that the task in the async was not a network call nor it was blocking the main thread.
Screenshot/s for the changes:
Video Link
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
main_tiles.zip