added a else statement to revert the color #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Oct 11, 2020
Comment on lines
491
to
493
| else{ | ||
| thermometer.setBackgroundCircleColor(Color.parseColor("#ff48cce9")); | ||
| } |
Collaborator
There was a problem hiding this comment.
Hello @Mayank9mare , There's a space missing after else block. Also rather than hard-coding property values, use resource files.
CloudyPadmal
requested changes
Oct 12, 2020
app/src/main/res/values/colors.xml
Outdated
| <color name="gray">#F2ECEC</color> | ||
| <color name="black">#000000</color> | ||
| <color name="background">#FAFAFA</color> | ||
| <color name="primaryBlue">#ff48cce9</color> |
Collaborator
There was a problem hiding this comment.
Make it consistence. ff48cce9 -> 48CCE9
Collaborator
|
Also squash the commits into one. https://github.com/fossasia/pslab-android#how-to-git-squash |
CloudyPadmal
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[#2136 ]
Changes: [Added a else statement in line 491 in ThermometerDataFragment.java and set the color to "#ff48cce9"]
Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a
*.gifcontaining a demonstration]
I have also referred the original repository of anastr/SpeedView(https://github.com/anastr/SpeedView) of PointerSpeedometer.
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]