Skip to content

fix: done button on keyboard will connect to ESP #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix: done button on keyboard will connect to ESP #2174

merged 1 commit into from
Apr 1, 2021

Conversation

@asaikarthikeya
Copy link
Member

@asaikarthikeya asaikarthikeya commented Jan 21, 2021 •
edited
Loading

Fixes #2175

Changes:

  1. Done button on keyboard.
  2. Press on done button to connect the USB.

Screenshot/s for the changes:

gyy.mp4

CodeWithSouma
CodeWithSouma approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@CodeWithSouma CodeWithSouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@CloudyPadmal CloudyPadmal added the Fix Solution to an existing issue in app label Apr 1, 2021
@CloudyPadmal CloudyPadmal changed the title Done button on keyboard , Click to connect usb. fix: done button on keyboard will connect to ESP Apr 1, 2021
@CloudyPadmal CloudyPadmal merged commit e18b331 into fossasia:development Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

+1 more reviewer

@CodeWithSouma CodeWithSouma CodeWithSouma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asaikarthikeya asaikarthikeya

Labels

Fix Solution to an existing issue in app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connect USB by clicking on done in keyboard

3 participants

@asaikarthikeya @CloudyPadmal @CodeWithSouma