updated setupGuideLayout in abstract class PSLabSensor to hide image if not available in a sensor's bottomsheet guide #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if not available in a sensor's bottomsheet guide
Member
asaikarthikeya
left a comment
asaikarthikeya
left a comment
There was a problem hiding this comment.
In every other instrument this space is filled with a PSlab hardware related image , I think adding a image would be better since it improve regularity in app . This would be a optimal solution till we get a image. Thank you.
CloudyPadmal
requested changes
Apr 1, 2021
Collaborator
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
Add an image instead of hiding the view.
Collaborator
|
Also try to shorten the PR title |
Contributor
Author
|
@CloudyPadmal what image should I add? |
Contributor
Author
|
The view is only hidden if there's no image to display like right now, do you want me to add a placeholder? |
CloudyPadmal
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: [empty imageview is sensors bottomsheet guide]
Changes: [updated setupGuideLayout in abstract class PSLabSensor to hide image if not available in a sensor's bottomsheet guide]
Screenshot/s for the changes:
Before-------------------------------------------------------------------------------------------------------------AfterChecklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xml