Changing to androidx for issues #2242 #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Oct 9, 2021
Collaborator
CloudyPadmal
left a comment
CloudyPadmal
left a comment
There was a problem hiding this comment.
Rest looks good. Also try to squash all the commits into one single commit for each PR from now onwards. Refer to how-to-git-squash
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Member
Author
|
@CloudyPadmal can you please review now the changes, I think changes are commited. |
CloudyPadmal
approved these changes
Oct 10, 2021
Member
Author
|
@CloudyPadmal bro can make more PR for this issue ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change xmls files to androidx for issues #2242