Skip to content

Removed flavor settings from app #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2022
Merged

Removed flavor settings from app #2308

merged 2 commits into from
Jan 25, 2022

Conversation

@apoorva-raj
Copy link
Contributor

@apoorva-raj apoorva-raj commented Jan 22, 2022

Fixes #2305

Changes:

Screen shots for the changes:

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

@apoorva-raj apoorva-raj mentioned this pull request Jan 24, 2022
Merged
5 tasks
@CloudyPadmal CloudyPadmal merged commit c910877 into fossasia:development Jan 25, 2022
@apoorva-raj apoorva-raj deleted the no-flavor branch January 25, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apoorva-raj @CloudyPadmal