Skip to content

Conversation

@AsCress
Copy link
Collaborator

@AsCress AsCress commented Mar 10, 2025

Fixes release pipeline.

Summary by Sourcery

CI:

  • Update the release pipeline to use the 'fastlane-android' branch instead of 'fastlane'.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 10, 2025

Reviewer's Guide by Sourcery

The pull request updates the release pipeline by renaming the Git branch used for deployment from 'fastlane' to 'fastlane-android' and ensures proper error handling in the production promotion step.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Renamed the Git branch used in the release pipeline.
  • Deleted the 'fastlane' branch.
  • Renamed the current branch to 'fastlane-android'.
  • Pushed the 'fastlane-android' branch to the remote repository with force.
.github/workflows/release.yml
Improved error handling in the production promotion step.
  • Added a conditional check to exit with status 1 if the 'promoteToProduction' command fails.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more descriptive branch name than fastlane-android.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@AsCress AsCress added the Chore Changes to things that do not go into production label Mar 10, 2025
@AsCress AsCress enabled auto-merge (squash) March 10, 2025 18:09
@AsCress AsCress requested a review from marcnause March 10, 2025 18:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

@AsCress AsCress requested a review from adityastic March 10, 2025 18:19
@AsCress AsCress merged commit 844ac12 into development Mar 10, 2025
4 checks passed
@AsCress AsCress deleted the AsCress-patch-1 branch March 10, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore Changes to things that do not go into production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants