Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to choose room #1581

Closed
wants to merge 2 commits into from

Conversation

batbrain7
Copy link
Member

Fixes #1580

parent issue #1489

@mariobehling
Copy link
Member

Please finalize this PR and resolve conflicts.

Copy link
Member

@arundhatigupta arundhatigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@batbrain7 As far as I understand, this PR simply adds an option to the UI, which is yet not functional, to change room. Would you please add a little info about this PR and the plan to implement this feature? Also, it would be great if you could please add a screenshot for the changes made. :)

@batbrain7
Copy link
Member Author

@arundhati24 no it is more complicated than just adding an option in the UI to change the room, I'll finalise this PR soon now. 😄

@batbrain7 batbrain7 closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option for adding room for the devices
3 participants