-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement recaptcha verification #2349
base: development
Are you sure you want to change the base?
Conversation
@iamareebjamal should we have this feature. This was implemented as discussed in the Gitter channel, regarding the changes in the server-side script. |
Discuss this with SUSI server guys |
We had a discussion regarding this in the gitter channel, they said to implement recaptcha. |
@iamareebjamal please review it. Also, please tell where to store the API key. |
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 3ff7a72. Here's the output:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 21ed178. Here's the output:
|
Please fix Travis. |
Please provide a screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other PR: We cannot keep the API key in the app itself. This would be a security issue. It should be added during building of the app using Travis environment variables. Please implement it in that way.
@atm1504 please refer to the way youtube API key is stored in the App. |
This PR is open for a long time, if anyone wants to take this up, they can |
Fixes #2348 , #2319
Changes:
Screenshots for the change:
Will be updated once complete