Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create enum for theme types #1492

Open
1 of 2 tasks
sakshee-19 opened this issue Apr 5, 2019 · 0 comments · May be fixed by #1494
Open
1 of 2 tasks

Create enum for theme types #1492

sakshee-19 opened this issue Apr 5, 2019 · 0 comments · May be fixed by #1494

Comments

@sakshee-19
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request

Current behavior:

Currently we are not using enum for any them type, which makes the theme type less configurable. And whenever we need to use theme types somewhere, we would need to write explicitly.

Expected behavior:

There should be a common enum for all the theme types at one place, and it should be used everywhere. If someone changes at one place, it will automatically replace its all instances. This could also be done for other types.

Screenshots of the issue:

Will work on the issue:
Yes

sakshee-19 added a commit to sakshee-19/susper.com that referenced this issue Apr 5, 2019
simsausaurabh pushed a commit to sakshee-19/susper.com that referenced this issue Apr 5, 2019
@sakshee-19 sakshee-19 linked a pull request Apr 5, 2019 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant