-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Live-Edits of any Property of any Plot #837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is really cool! As with all cool features at this scale though, I have a few questions/concerns to discuss before moving forward with it. Overall I think the choice to reuse the properties list was really clever, but there's a little work to be done for proper state/props management here. (I think in some ways you're being held back by the component-style react that Visdom has been built on, as it can make state maintenance harder to follow, and updates less clear.) In any case we can start the discussion primarily around the direct changes to props.content
in Pane.js
.
One additional thing:
|
Final Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, and for the overall feature here! This is a really cool addition to Visdom and I'm sure it'll see use 👍
Description
Adding possibility to change all available plotpanes (e.g. axis-limits) on-the-fly.
The feature added can be most easily explained by the short video added below.
Motivation and Context
Pretty often I find myself restarting a script because a specific setting of a plot cannot be adapted easily in visdom.
This feature tries to solve this by adding the option to edit all
pane.content
variables on-the-fly.Some more details on the implementation:
PropertiesPane
by adding aAbstractPropertiesList
Component.PropertyList
is added to the generalPane
. I see that one could argue for a more specific implementation, possibly addit it only toPlotPane
or so, but I felt that this feature could be expanded to a more general feature, usable by other types of panes as well.Pane
-object basis i have added the optionenablePropertyList
, andPlotPane
is using it to enable the feature in all plots.editParameters
-Button in the top-right corner of every plot. The button turns red when enabled and closes the window again when pressed a second time.How Has This Been Tested?
I have to admit that I have tried some, but not all parameters used in
demo.py
.Screenshots (if appropriate):
Types of changes
Checklist:
-> This is just a proposal for a place to mention this feature. I have used the previous video and placed it in the README.md where it fitted best in my opinion. AFAIK upload from PRs cannot be removed and will be accessible even after closing the PR.