Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for differing binary names #12

Closed
hisbaan opened this issue Apr 18, 2022 · 3 comments · Fixed by #13
Closed

Add support for differing binary names #12

hisbaan opened this issue Apr 18, 2022 · 3 comments · Fixed by #13

Comments

@hisbaan
Copy link

hisbaan commented Apr 18, 2022

For example, my package, didyoumean builds a binary called dym with this addition to the Cargo.toml file:

[[bin]]
name = "dym"
path = "src/main.rs"

The script fails when running strip as the binary name is not as the script expects. The issue is with line 246 of main.rs: binary.push(&package.name); which assumes that package.name is the same as the produced binary.

I don't know enough about Cargo.toml parsing so I'm not sure how to parse a new field exactly and to change the binary path optionally if that field exists, however I would be glad to work on it if someone could point me in the right direction.

@fosskers
Copy link
Owner

This would be an easy fix for me, let me take care of it. Thanks for bringing this to my attention.

@hisbaan
Copy link
Author

hisbaan commented Apr 18, 2022

Awesome! Thank you so much :) It's a relatively niche configuration I suppose

@fosskers fosskers linked a pull request Apr 19, 2022 that will close this issue
@fosskers
Copy link
Owner

I've put up a PR that implements this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants