Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented audio selector #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implemented audio selector #92

wants to merge 2 commits into from

Commits on Jun 25, 2023

  1. Added Subtitle Track selector

    Implemented the ability to select a subtitle track on the video player
    page.
    
    Added a SubtitleAudioTrackSelector UserControl. This UserControl hosts
    the subtitle tracks and will also host the audio tracks from which a
    user can select a track.
    
    Introduced a MediaTrackService which can be injected to provider some
    methods. Methods it provide are at this moment the retrieval of subtitle
    tracks and the preferred subtitle track. Due to LibVLC not being able to
    be injected by a dependency injector due to several reasons, this
    service needs to be initialized by calling the initialize method and
    providing it with a reference to a (initialized!) MediaPlayer instance. This service can be expanded to
    perform more general MediaPlayer tasks as well in the future if need be.
    
    Added a ValueConverterGroup enabling the chaining of value converters.
    
    Added a custom exception which gets thrown when one of the the MediaTrackService
    methods get called without the service being initialized.
    
    Added MediaTrackService to the dependency Injector container in App.xaml.cs.
    
    Replaced public mediaplayer property calls with private.
    TimGels committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    5ae0be5 View commit details
    Browse the repository at this point in the history
  2. Implemented audio track selector

    Audio tracks can now be selected. By default it will select the first
    actual audio track.
    TimGels committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    cf3246a View commit details
    Browse the repository at this point in the history