Add support for custom open/close tags #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevereOverfl0w
force-pushed
the
dmonroe/openclose
branch
2 times, most recently
from
ae49c6c
to
96168bb
Compare
SevereOverfl0w
force-pushed
the
dmonroe/openclose
branch
from
96168bb
to
0c917b8
Compare
SevereOverfl0w
force-pushed
the
dmonroe/openclose
branch
from
0c917b8
to
05fbb41
Compare
SevereOverfl0w
changed the title
|
Tests are all passing now, and I've added some tests for various edge-cases. I think this is ready for review! |
|
Thanks @SevereOverfl0w for contributing. Do you know if this is a feature that other mustache implementations have? |
|
The JavaScript implementation provides this option, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for specifying the open/close tags before the rendering
has started. I think I've missed a few edge cases still.