Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to run multigpu training, we explicitly set:
before launching the trainer. However, the Accelerator state doesn't always define the
fsdp_plugin
attribute, so this can crash in a cryptic way if we launch with Torchrun for multigpu with the wrong settings.The
fsdp_plugin
of the Accelerator state for multigpu configurations is set here in the Accelerate source. If you don't setACCELERATE_USE_FSDP
, it won't be defined.This PR explicitly checks to see if the accelerator state has an
fsdp_plugin
before trying to update the auto wrap policy; if it doesn't, it raises an attribute error with a hint that you probably need to setACCELERATE_USE_FSDP
to run with a multigpu configuration.