-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect usage for the Cite element #10226
Comments
Seems consistent with the specification; its first example is: <p>In the words of <cite>Charles Bukowski</cite> -
<q>An intellectual says a simple thing in a hard way. An artist says a hard thing in a simple way.</q></p> Presumably the person's name serves as a proxy to the "written or oral statement" being cited. That example highlights another issue, though. Foundation naively styles all citations as blocks, interfering with simple inline usage. That behavior should probably be scoped to block quotes. |
I think @AndrewKvalheim you are probably correct that cite should probably not be a block element. Looking to see when that was introduced, it appears to have been pulled over from Foundation 5. Wonder if any of @brettsmason @gakimball @andycochran or other old guard folks know why that was the case, or have opinions on this subject? |
+1! "That example highlights another issue, though. Foundation naively styles all citations as blocks, interfering with simple inline usage. That behavior should probably be scoped to block quotes." |
Although the W3C shows examples of using a person's name, they contradict themselves in the opening two statements.
They then explain what a creative work is, which does not include a person.
And then with more research, I came across "Examples of block quote metadata" which bases its structure on the Chicago Manual of Style. Also using HTML5Doctor.com cite reference it states as the W3C does about what is Creative Works. My suggestion is Foundation should just remove the styling on the cite element allowing the user to style how he/she see's fit. This would allow anyone to use it in the manner they desire, without doing the dreaded overwrites. |
What about that "or the name of the author" part? |
@AndrewKvalheim that is why I stated the W3C contradicted themselves. They say "the cite element represents a reference to a creative work", in the first sentence after the data. Then the very next paragraph they define what is creative work. Which does NOT include an author or person name. |
I'm going to close this. But let's definitely consider all this input for v7. |
How to reproduce this bug:
When using a blockquote or q element the developer should include a cite attribute or cite element. However, the current usage for cite by Foundation is incorrect.
What should happen:
According to: MDN and HTML 5 Doctor the cite should be:
What happened instead:
Foundation is currently using a person's name.
Recommendation for fixing issue:
Person name:
<span class="cite">Person Name</span>
Citing a piece of work:
<cite>[Book Title|Movie Title...]</cite>
The text was updated successfully, but these errors were encountered: