Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline <cite> elements #10687

Merged
merged 4 commits into from
Dec 26, 2017
Merged

Allow inline <cite> elements #10687

merged 4 commits into from
Dec 26, 2017

Conversation

jmsfwk
Copy link
Contributor

@jmsfwk jmsfwk commented Sep 29, 2017

Move the block styling and reduced font size on <cite> to only
apply when it is a child of <blockquote>.

Fixes issue #10226

@kball
Copy link
Contributor

kball commented Oct 3, 2017

This makes sense to me, but is a breaking change... can we wrap up the block form of citation into a mixin so that if someone wants to re-instate the old behavior it is as simple as

cite {
  @include block-citation();
}

Move the block styling and reduced font size on `<cite>` to only
apply when it is a child of `<blockquote>`.

Fixes issue #10226
@ncoden
Copy link
Contributor

ncoden commented Dec 26, 2017

Hey @jmsfwk. Thank you, I see you made the requested changes, and sorry for the late reply. I think this PR goes to the right direction, which is trying to not impose any design and simply providing a set of easily customizable tools.

It's sad I was not active when you opened this PR, I would recommand a more "component" approach rather than "allowing a old-behavior reset". Anyway, I'll take care of the changes and merge this right after.

Sorry again for the late reply.

…cite>

Note: this remove the backward incompability included in 18af0ed
@ncoden
Copy link
Contributor

ncoden commented Dec 26, 2017

@jmsfwk For your future pull requests, you can create a dedicated branch (like feat/optional-block-cite) and create a pull request from it. So you can continue working on your branch develop while this PR is open.

@ncoden
Copy link
Contributor

ncoden commented Dec 26, 2017

I pushed.
Now we have a .cite-block component, generated from its cite-block() mixin, and used as default (or not) for the <cite> tag according to the $enable-cite-block property.

So no migration is needed anymore, and we're slowly moving to a "component" approach for typography.

@ncoden ncoden merged commit 60d47ab into foundation:develop Dec 26, 2017
@ncoden ncoden modified the milestones: 6.6.0, 6.5.0 Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants