Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magellan w/ deep linking doesn't clear the hash when there's no longer an active link #10836

Closed
nvenegas opened this issue Jan 3, 2018 · 2 comments

Comments

@nvenegas
Copy link
Contributor

nvenegas commented Jan 3, 2018

How to reproduce this bug:

On a page with with Magellan and data-deep-linking enabled and a top-margin greater than data-threshold (defaults to 50px) such that there is no active link until you scroll past that top-margin:

  1. Load the page (without a hash).
  2. Scroll down to the first Magellan-tracked element such that the window's location updates to that element's ID (e.g., #first-heading).
  3. Scroll back to the very top (e.g., by pressing HOME on your keyboard).

What should happen:

What should happen after each of the steps to reproduce:

  1. The window's location should not have a hash.
  2. The window's location should have a hash of #first-heading.
  3. The window's location should not have a hash.

What happened instead:

What actually happens after each of the steps to reproduce:

  1. The window's location does not have a hash.
  2. The window's location has a hash of #first-heading.
  3. The window's location has a hash of #first-heading.

Browser(s) and Device(s) tested on:

Chrome 63.0.3239.84 on macOS Sierra (10.12.6)

Foundation Version(s) you are using:

6.4.3

@nvenegas
Copy link
Contributor Author

nvenegas commented Jan 3, 2018

I'll have a pull request with a fix up shortly!

@nvenegas
Copy link
Contributor Author

nvenegas commented Jan 3, 2018

The bug is reproducable in the magellan/active-item.html visual test (via npm run test:visual).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants