Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Off Canvas] Off canvas not visible with revealOn option passed without .reveal-on classes #10867

Closed
ncoden opened this issue Jan 17, 2018 · 0 comments · Fixed by #10868
Closed

[Off Canvas] Off canvas not visible with revealOn option passed without .reveal-on classes #10867

ncoden opened this issue Jan 17, 2018 · 0 comments · Fixed by #10868
Assignees
@ncoden
Labels
🐛bug Off-Canvas PR open
Milestone
6.5.0

Comments

@ncoden
Copy link
Contributor

ncoden commented Jan 17, 2018

The Off-canvas revealOn option is infered from its class (.reveal-on-medium == revealOn: 'medium',), but the .reveal-on class is not set when revealOn alone is given, while it is required for the off-canvas to be visible.

How to reproduce this bug:

  • Create an Off-canvas with [data-revealed="true"] and [data-reveal-on=...]
  • Look, and see......

What should happen:

The Off Canvas is visible.

What happened instead:

The Off Canvas takes the place but is not visible.

Foundation Version(s) you are using:

Foundation v6.4.3

Test case link:

https://codepen.io/ncoden/pen/Rxevga
@ncoden ncoden added this to the 6.4.4 milestone Jan 17, 2018
@ncoden ncoden self-assigned this Jan 17, 2018
@ncoden ncoden changed the title [Off Canvas] Off canvas is visible with revealOn option passed without .reveal-on classes [Off Canvas] Off canvas not visible with revealOn option passed without .reveal-on classes Jan 17, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this issue Jan 17, 2018
@ncoden
fix: fix off-canvas option revealOn when used without classes found…
594cf65 
…ation#10867

Closes: foundation#10867
@ncoden ncoden mentioned this issue Jan 17, 2018
Merged
@ncoden ncoden added the PR open label Jan 17, 2018
ncoden added a commit that referenced this issue Jan 22, 2018
@ncoden
Merge pull request #10868 from ncoden/fix/off-canvas-reveal-on-option…
f9173b4 
…-10867

fix: fix off-canvas option `revealOn` when used without classes #10867
ncoden added a commit to ncoden/foundation-sites that referenced this issue Jun 16, 2018
@ncoden
Use pull request foundation#10868 from ncoden/fix/off-canvas-reveal-o…
1bd17f5 
…n-option-10867 for v6.5.0

ee3399b Revert "fix: prevent side-effect from .stack-for in media-object"
594cf65 fix: fix off-canvas option `revealOn` when used without classes foundation#10867
23da69d test: add visual test for off-canvas revealOn option
5255360 fix: fix merge fail in off-canvas
a2d431a fix: fix Off-canvas `revealOn` option when used with `revealClass` option
05697a0 fix: fix regexp check for revealClass option in Off-Canvas
72f7e40 feat: expose RegExpEscape
13202d0 test: add tests for `RegExpEscape`

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncoden ncoden

Labels
🐛bug Off-Canvas PR open
Projects
None yet
Milestone
6.5.0
Development

Successfully merging a pull request may close this issue.

fix: fix off-canvas option revealOn when used without classes #10867 ncoden/foundation-sites
1 participant
@ncoden