Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the current state of unit tests #10945

Closed
3 tasks done
DanielRuf opened this issue Feb 15, 2018 · 5 comments
Closed
3 tasks done

the current state of unit tests #10945

DanielRuf opened this issue Feb 15, 2018 · 5 comments
Assignees

Comments

@DanielRuf
Copy link
Contributor

DanielRuf commented Feb 15, 2018

  • standalone chai and mocha in test directory and other (unused) files
  • browserstack tests running on IE11 producing wrong calculation of width and height values
  • a few failing unit tests in the browserstack tests
  • triggered events can produce race conditions under some circumstances as the DOM is not fast enough in the testing env
  • in general: inconsistent event names (open/opened, close/closed)
  • currently the testsuite is only tested on Node.js 6. We should also test it on Node.js 4, 8 and 9.
  • ...

Todo:

  • cleanup directories
  • update deps
  • create build matrix for Travis (just add more Node.js versions)
@ncoden
Copy link
Contributor

ncoden commented Feb 15, 2018

Agreed with all that.

Related PR:

Also related to this issue:

@DanielRuf DanielRuf self-assigned this Feb 25, 2018
@DanielRuf
Copy link
Contributor Author

So far so good. Now we just need new testrunner files, IE11 fixes and better event names #10949

@DanielRuf
Copy link
Contributor Author

browserstack tests running on IE11 producing wrong calculation of width and height values

#11078

@DanielRuf
Copy link
Contributor Author

@ncoden
Copy link
Contributor

ncoden commented Apr 28, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants