getFnName unit tests ADDED #10941
Merged
getFnName unit tests ADDED #10941
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
approved these changes
Feb 14, 2018
|
@dragthor I seen your comment in #8311 (comment). Do you plan to add any others tests in this PR ? You can open/rename a PR with the [WIP] tag. |
|
Separate PR. |
|
Ok then... |
|
Note: tests are being repaired in #10943. |
3 tasks
|
Let me figure this out. Edge "" |
|
I need to remove the unnamed function expression test case. |
|
Seems some (newer) browsers use the variable name for automatic namespacing. Is it safe to remove the unnamed function expression test case? |
|
As there is no consistent behavior we can expect (but just "we found a name", or "we were not able to get a name", and unless we find a polyfill (for new or old browsers), we should not test this case. |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Feb 26, 2018
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…6.5.0 5137351 getFnName unit tests Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation.getFnName()unit tests added.