Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: unclear that data-toggler supports .class and class #11013

Closed
DanielRuf opened this issue Mar 5, 2018 · 1 comment
Closed

docs: unclear that data-toggler supports .class and class #11013

DanielRuf opened this issue Mar 5, 2018 · 1 comment
Assignees
@DanielRuf
Labels
📖 documentation PR open Toggler

Comments

@DanielRuf
Copy link
Contributor

In the docs I see no mention that the data-toggler accepts .class and class as value.

We should prefer the version without the dot but mention that we also support the dot notation (just one class).

https://github.com/zurb/foundation-sites/blob/develop/js/foundation.toggler.js#L55
@DanielRuf DanielRuf self-assigned this Mar 9, 2018
@DanielRuf DanielRuf mentioned this issue Mar 9, 2018
Merged
@DanielRuf
Copy link
Contributor Author

Closing as the linked PR is merged now.

This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRuf DanielRuf

Labels
📖 documentation PR open Toggler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielRuf @colin-marshall