Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make clear that data-toggler of toggler supports .classname and… #11031

Merged
merged 2 commits into from Mar 11, 2018
Merged

docs: make clear that data-toggler of toggler supports .classname and… #11031

merged 2 commits into from Mar 11, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Mar 9, 2018 •
edited
Loading

It is not clear from the docs that .classname and classname are accepted and work.

Closes #11013

@ncoden
Copy link
Contributor

ncoden commented Mar 9, 2018

@DanielRuf The "issue" you are targeting it the PR itself.

@DanielRuf
Copy link
Contributor Author

@DanielRuf The "issue" you are targeting it the PR itself.

Updated

ncoden
ncoden reviewed Mar 9, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I did not found others similar cases in the framework.

docs/pages/toggler.md Outdated
@@ -8,7 +8,7 @@ video: 'wHpZCrpKlBc'

## Toggle a CSS class

To setup a class toggle, start by adding the attribute `data-toggler` to an element. The value of `data-toggler` is the class you want to toggle. Also give the element a unique ID so it can be targeted.
To setup a class toggle, start by adding the attribute `data-toggler` to an element. The value of `data-toggler` is the class you want to toggle (supports `.classname` and `classname`). Also give the element a unique ID so it can be targeted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

(like .classname and classname)

Sounds more consistent with a "familiar" description of the component options, rather than a strict settings reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

ncoden
ncoden approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@DanielRuf DanielRuf removed the PR open label Mar 10, 2018
@ncoden ncoden merged commit d4ad21d into foundation:master Mar 11, 2018
@DanielRuf DanielRuf deleted the docs/toggler-data-toggler-classname-notation-11013 branch March 11, 2018 23:19
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#11031 from DanielRuf/docs/toggler-data-to…
cbfe9e4 
…ggler-classname-notation-11013 for v6.5.0

c635d98 docs: make clear that data-toggler of toggler supports .classname and classname
b8feea6 docs: improve wording in toggler docs

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
📖 documentation Toggler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden