Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use XY Grid #11028

Closed
ghost opened this issue Mar 8, 2018 · 5 comments
Closed

Update examples to use XY Grid #11028

ghost opened this issue Mar 8, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 8, 2018

In the documentation for Foundation 6.4.1 it starts by saying how XY Grid is the new grid and that Float Grid and and Flex Grid are now legacy features and how XY Grid is enabled by default. Thats great, however, every example in the documentation for every feature still uses the old legacy Float Grid as the grid for the examples. Please update the documentation because this makes the examples unusable in a XY Grid project.

@DanielRuf
Copy link
Contributor

Can you show specific examples which use the old grid instead of the new xy grid?

@colin-marshall
Copy link
Contributor

Equalizer is the only one I could find.

@dogpatchmedia also may be referring to the grid used to build examples (e.g. thumbnail example with 3 columns) and not the actual code you can copy/paste of the examples. If that's what is being referred to, yes they probably should all be XY-Grid eventually, but it's low priority at the moment.

@ghost
Copy link
Author

ghost commented Mar 9, 2018

Hey @colin-marshall and @DanielRuf, I think colin is right that Equalizer is the one that got my attention. I appreciate you being so attentive and yeah its low priority for sure I understand, it just irritated me since this is the first project I've worked on using the XY Grid and Im not used to it quite yet.

@rafibomb
Copy link
Member

Technically, equalizer was a viable solution before flexbox created equal height children. Since using flexbox, we have not needed it on any of our projects.

Perhaps we just label this example as such and close the issue?

@ncoden ncoden closed this as completed Apr 10, 2018
@ncoden
Copy link
Contributor

ncoden commented Apr 10, 2018

Thanks for the bump @rafibomb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants