-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: migrate docs examples to xy-grid #11034
docs: migrate docs examples to xy-grid #11034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole documentation still uses the Float Grid. Why only equalizer.md
?
Also, I'll see if we can get a CodePen pro account to work on pens together without having fork them & change URLs to make a change.
@ncoden are there other components that use the float grid in the code examples? That's what I was going for first. |
I now see Abide uses float grid too. I targeted develop on this PR mistakenly. I should probably close this out and start over. |
0253723
to
2e9099b
Compare
@ncoden I think I got them all now. |
@colin-marshall Thanks, that awesome ! Did you made a visual check of everything ? |
I did a visual test for all of them but somebody should probably do a quick double check before merge. I’ll squash the commits and force push the updated branch. |
d7047bf
to
de70238
Compare
Hi @colin-marshall, there are some conflicts that have to be resolved. |
<div class="column row"><div class="row collapse"> | ||
<div class="large-3 medium-4 columns" data-sticky-container> | ||
<ul class="vertical menu"> | ||
<div class="row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also use the new grid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example was derived from style sherpa, so the grid needs to be changed on that repo first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. The rest seems to be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you @colin-marshall
…alizer-grid-examples for v6.5.0 de70238 chore: migrate docs to use xy-grid in examples Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Closes #11028. Also updated the CodePens.