Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate docs examples to xy-grid #11034

Merged

Conversation

colin-marshall
Copy link
Contributor

Closes #11028. Also updated the CodePens.

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole documentation still uses the Float Grid. Why only equalizer.md ?

Also, I'll see if we can get a CodePen pro account to work on pens together without having fork them & change URLs to make a change.

@colin-marshall
Copy link
Contributor Author

colin-marshall commented Mar 10, 2018

@ncoden are there other components that use the float grid in the code examples? That's what I was going for first.

@colin-marshall
Copy link
Contributor Author

I now see Abide uses float grid too. I targeted develop on this PR mistakenly. I should probably close this out and start over.

@ncoden
Copy link
Contributor

ncoden commented Mar 10, 2018

You can search column/columns in all .md files 😉

Screenshot

@colin-marshall colin-marshall changed the title docs: migrate equalizer examples to xy-grid docs: migrate docs examples to xy-grid Mar 10, 2018
@colin-marshall colin-marshall force-pushed the docs/update-equalizer-grid-examples branch from 0253723 to 2e9099b Compare March 14, 2018 03:46
@colin-marshall colin-marshall changed the base branch from develop to master March 14, 2018 03:47
@colin-marshall
Copy link
Contributor Author

@ncoden I think I got them all now.

@ncoden
Copy link
Contributor

ncoden commented Mar 14, 2018

@colin-marshall Thanks, that awesome ! Did you made a visual check of everything ?
You can probably squash too since there is a lot of commits and the PR is clean (no changes requested).

@colin-marshall
Copy link
Contributor Author

I did a visual test for all of them but somebody should probably do a quick double check before merge. I’ll squash the commits and force push the updated branch.

@colin-marshall colin-marshall force-pushed the docs/update-equalizer-grid-examples branch from d7047bf to de70238 Compare March 15, 2018 00:10
@DanielRuf
Copy link
Contributor

Hi @colin-marshall, there are some conflicts that have to be resolved.

@DanielRuf DanielRuf self-requested a review March 24, 2018 19:51
<div class="column row"><div class="row collapse">
<div class="large-3 medium-4 columns" data-sticky-container>
<ul class="vertical menu">
<div class="row">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also use the new grid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example was derived from style sherpa, so the grid needs to be changed on that repo first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. The rest seems to be fine.

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @colin-marshall

@ncoden ncoden merged commit 4634b50 into foundation:master Mar 24, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…alizer-grid-examples for v6.5.0

de70238 chore: migrate docs to use xy-grid in examples

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants