Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumnail class anchor elements don't fill thumbnail "frame" when image is smaller than its container #11029

Closed
colin-marshall opened this issue Mar 9, 2018 · 1 comment

Comments

@colin-marshall
Copy link
Contributor

colin-marshall commented Mar 9, 2018

How to reproduce this bug:

  1. Go to https://foundation.zurb.com/sites/docs/thumbnail.html
  2. Enlarge browser window 1350px or wider
  3. Observe middle thumbnail example of .thumbnail class on anchor tag

What should happen:

Middle thumbnail image should appear like the first and third/last thumbnail

What happened instead:

screen shot 2018-03-08 at 8 13 30 pm

--

This happens because the max-width: 100% on the anchor makes the thumbnail "frame" take up the width of the parent container. When the image, at its largest width, is smaller than the container, you get the result above.

This is easily fixable with some extra CSS, but I am not sure if there's a good reason to support having the thumbnail class on the anchor tag because it defeats the purpose if you have to add custom CSS rules to make it work.

@DanielRuf
Copy link
Contributor

DanielRuf commented Mar 9, 2018

See foundation/foundation-docs#30

This is no bug in Foundation Sites, the styles are only in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants