-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use display table for the thumnails in the docs #30
fix: use display table for the thumnails in the docs #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no bug in Foundation Sites, the styles are only in the docs.
-- foundation/foundation-sites#11029 (comment)
It's hard to believe as this change the style and behavior of the thumbnail itself.
display: block
should not have been applied in the first place. I think that a solution like text-align: center
on the parent (the column) is far more cleaner and less conducive to unwanted side effects.
Just the doc styles are problematic.
This will not work here ;-) |
I mean, by removing |
Would be a cleaner approach, right. I'll change it. |
But wait, the codepen does not center them https://codepen.io/IamManchanda/pen/EmLexY?editors=1100 So we should be consistent. To center or not to center? |
I vote for "to center" ;) |
And the example uses the float grid (not the new xy grid) which has no center class or did I oversee something? |
|
What was that ? 😄 |
? =/ I accidentally deleted it, nothing more. Sorry for the confusion. The GitHub UI is crap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks. You can update foundation-docs
in foundation/foundation-sites#11032
The styles of the thumbnails in the docs use
display: block
with auto margins on both sides for exemplary centering them.
But this does not work well with
display: block
on an a tag.display: table
text-center
on the parent works much better in this example which is just for the docs and demonstrating the thumbnails.Closes foundation/foundation-sites#11029