Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.5.0 RC1: responsive accordion tabs do not work anymore #11360

Closed
5 tasks done
DanielRuf opened this issue Jun 28, 2018 · 3 comments · Fixed by #11366
Closed
5 tasks done

6.5.0 RC1: responsive accordion tabs do not work anymore #11360

DanielRuf opened this issue Jun 28, 2018 · 3 comments · Fixed by #11366
Labels
🐛bug PR open Responsive Accordion Tabs v6.5.0-rc.1

Comments

@DanielRuf
Copy link
Contributor

Expected Behavior

responsive accordion tabs should work, they should switch between tabs and accordions.

Current Behavior

It does not change between tabs and accordions.

Possible Solution

Test Case and/or Steps to Reproduce (for bugs)

Test Case: https://codepen.io/DanielRuf/pen/MXzvMM?editors=1100

How to reproduce:

  1. https://codepen.io/DanielRuf/pen/MXzvMM?editors=1100
  2. resize viewport

Context

Your Environment

  • Foundation version(s) used:
  • Browser(s) name and version(s):
  • Operating System and version (desktop or mobile):
  • Link to your project:

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • This is a bug report or a feature request.
  • There are no other issues similar to this one.
  • The issue title is descriptive.
  • The template is fully and correctly filled.
@ncoden
Copy link
Contributor

ncoden commented Jun 29, 2018

This comes from the resize.zf.mediaquery event listenner being removed after the component initialization. I really don't understand where.

@DanielRuf
Copy link
Contributor Author

Should we do some bisecting?

ncoden added a commit to ncoden/foundation-sites that referenced this issue Jun 30, 2018
@ncoden
fix: prevent removing all listeners by checking them before unbinding
ff59e57 
$(...).off(undefined) removes all the attached event listeners, including those outside Foundation of unrelated to the issue.

This commit fixes foundation#11360 and probably others issues by checking for variables expected to be listeners names before using it to remove the listeners.

[This fix is compatible with v6.5]
ncoden added a commit to ncoden/foundation-sites that referenced this issue Jun 30, 2018
@ncoden
fix: prevent removing all listeners by checking them before unbinding
2c8485f 
$(...).off(undefined) removes all the attached event listeners, including those outside Foundation of unrelated to the issue.

This commit fixes foundation#11360 and probably others issues by checking for variables expected to be listeners names before using it to remove the listeners.

[This fix is compatible with v6.5]

Closes foundation#11360
@ncoden ncoden mentioned this issue Jun 30, 2018
Merged
14 tasks
@ncoden ncoden added the PR open label Jun 30, 2018
@ncoden
Copy link
Contributor

ncoden commented Jun 30, 2018

See #11366

This was referenced Jul 3, 2018
Closed
Merged
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug PR open Responsive Accordion Tabs v6.5.0-rc.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent removing all listeners by checking them before unbinding ncoden/foundation-sites
2 participants
@DanielRuf @ncoden