Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specificity of the placeholder styles... #8366

Closed
LDigital84 opened this issue Mar 8, 2016 · 4 comments
Closed

Specificity of the placeholder styles... #8366

LDigital84 opened this issue Mar 8, 2016 · 4 comments
Labels

Comments

@LDigital84
Copy link

Is there a reason for the specificity of the placeholder styles? IE:

input::-webkit-input-placeholder,
textarea::-webkit-input-placeholder {
  color: #cacaca; }

input::-moz-placeholder,
textarea::-moz-placeholder {
  color: #cacaca; }

input:-ms-input-placeholder,
textarea:-ms-input-placeholder {
  color: #cacaca; }

input::placeholder,
textarea::placeholder {
  color: #cacaca; }

I have to use !important to override these styles because I do not use input before the style. Is there a reason I should be using input to style the placeholder? Why not use this:

::placeholder{
  color: #cacaca; }

If there is a reason, I'd love to know so I can improve my code. :)

Also, in my opinion, the color is too light and should be a touch darker.

@gakimball gakimball added the scss label Mar 8, 2016
@gakimball
Copy link
Contributor

Makes sense, if you want to write a PR we can pull it in.

As for the color, we have three standard shades of gray we use. As I recall, the $medium-gray was too dark, which is why we went with $light-gray.

@LDigital84
Copy link
Author

No worries on the color, that's more of an opinion and one that is easy to override. I'll look at a PR for this but I'm swamped for the next few days so anyone is welcome to go ahead. :)

@colin-marshall
Copy link
Contributor

@ncoden @brettsmason is it ok to close this one out?

@ncoden
Copy link
Contributor

ncoden commented Jan 28, 2018

This is generated there: https://github.com/ncoden/foundation-sites/blob/85c4e889ab8b1ab7ebda94fbc723330402191683/scss/forms/_text.scss#L143

I think we should resolve this issue. I'll submit a PR.

ncoden added a commit to ncoden/foundation-sites that referenced this issue Jan 28, 2018
kball added a commit that referenced this issue Feb 3, 2018
…ity-8366

fix: reduce placeholder specificity #8366
ncoden added a commit to ncoden/foundation-sites that referenced this issue Jun 16, 2018
…specificity-8366 for v6.5.0

c72b876 fix: reduce placeholder specificity foundation#8366

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants