-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specificity of the placeholder styles... #8366
Comments
Makes sense, if you want to write a PR we can pull it in. As for the color, we have three standard shades of gray we use. As I recall, the |
No worries on the color, that's more of an opinion and one that is easy to override. I'll look at a PR for this but I'm swamped for the next few days so anyone is welcome to go ahead. :) |
@ncoden @brettsmason is it ok to close this one out? |
This is generated there: https://github.com/ncoden/foundation-sites/blob/85c4e889ab8b1ab7ebda94fbc723330402191683/scss/forms/_text.scss#L143 I think we should resolve this issue. I'll submit a PR. |
…ity-8366 fix: reduce placeholder specificity #8366
…specificity-8366 for v6.5.0 c72b876 fix: reduce placeholder specificity foundation#8366 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Is there a reason for the specificity of the placeholder styles? IE:
I have to use
!important
to override these styles because I do not useinput
before the style. Is there a reason I should be usinginput
to style the placeholder? Why not use this:If there is a reason, I'd love to know so I can improve my code. :)
Also, in my opinion, the color is too light and should be a touch darker.
The text was updated successfully, but these errors were encountered: