-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Documentation suggests invalid HTML role="navigation" #9334
Comments
Owlbertz
added a commit
to Owlbertz/foundation
that referenced
this issue
Feb 5, 2018
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for Pagination includes this example:
<ul class="pagination" role="navigation" aria-label="Pagination">
with this comment:
I noticed my IDE warning that
"navigation"
is not an acceptable value for therole
element in this context. At first I thought this was a bug in the IDE, but more research confirmed this:http://stackoverflow.com/a/14181478/29470 says:
This can be confirmed in the HTML5 spec
Maybe it would be better to suggest wrapping the
<ul>
in a<nav>
element instead.The text was updated successfully, but these errors were encountered: