Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input Group] Flex-mode input group input height does not match non-input-group inputs #9344

Closed
simshaun opened this issue Nov 7, 2016 · 6 comments

Comments

@simshaun
Copy link
Contributor

simshaun commented Nov 7, 2016

Foundation 6.2.4

I'm being pedantic...

An input-group input's height does not match up with non-input-group inputs when displayed side-by-side as in the demo. It's off by a few pixels.

Demo:

http://simshaun-static.s3-website-us-east-1.amazonaws.com/foundation/6.2.4/

Example:

image

Removing height: auto on .input-group-field solves the problem, but I don't know if that causes issues elsewhere or if it causes problems in non-flex mode.

@simshaun simshaun changed the title [Input Group] Flex-mode input height does not match non-input-group inputs [Input Group] Flex-mode input group input height does not match non-input-group inputs Nov 7, 2016
@glen-84
Copy link
Contributor

glen-84 commented Mar 15, 2017

I'm going to use this for now:

.input-group-field {
    height: ($input-font-size + ($form-spacing * 1.5) - rem-calc(1));
}

I'm not sure why Foundation uses explicit heights for text inputs.

@developer-lindner
Copy link

developer-lindner commented Aug 22, 2017

The formular should be removed or signed as !default... actually it's impossible to have a input field with a height of 46px!
Why? just why? :D

Add $input-height maybe? or remove this entirely?

@kball
Copy link
Contributor

kball commented Aug 26, 2017

Has this been resolved as of #10456 ?

@simshaun
Copy link
Contributor Author

simshaun commented Aug 28, 2017

I just tested against the develop branch and it looks like this now:

image

@kball
Copy link
Contributor

kball commented Aug 30, 2017

Interesting... I think what might have happened is that the outside input group formula got changed in #9681 but within input group did not. We can probably just apply that change to scss/forms/_input-group.scss as well. @simshaun any interest in trying that out and maybe putting together a PR for this?

@simshaun
Copy link
Contributor Author

PR created, #10602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants