Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #9766 #10360

Merged
merged 3 commits into from
Jul 21, 2017
Merged

Fixed #9766 #10360

merged 3 commits into from
Jul 21, 2017

Conversation

hikouki
Copy link

@hikouki hikouki commented Jul 7, 2017

Hi! ✈️

Changed Dropdown panes so that it is arranged with the position of primary anchor as a reference.

It may not be a beautiful code... 😨
What would you do if you were me?

Changed Dropdown panes so that it is arranged with the position of primary anchor as a reference.
@kball
Copy link
Contributor

kball commented Jul 7, 2017

Hi @hikouki,
Thanks for the PR! I think this is broadly the right approach, but what I'd love to see is if we can solve this without storing the data on the DOM object itself, but rather store a reference to the current/primary in the javascript itself... we're moving towards more of a state-driven approach to the javascript and planning to abstract the DOM interactions behind and interface, so the more we can keep this as pure JS state the better.

@hikouki
Copy link
Author

hikouki commented Jul 8, 2017

I'll try! 👍

@hikouki
Copy link
Author

hikouki commented Jul 8, 2017

I tried. :)
How does it? @kball

@kball
Copy link
Contributor

kball commented Jul 8, 2017

Looks great @hikouki! Would you be able to add a visual test or an example in the docs that we can use to straightforwardly test the behavior?

@hikouki
Copy link
Author

hikouki commented Jul 8, 2017

Leave it to me!

@hikouki
Copy link
Author

hikouki commented Jul 8, 2017

I did it. 🍣 @kball

@kball kball merged commit 5d560d4 into foundation:develop Jul 21, 2017
@kball
Copy link
Contributor

kball commented Jul 21, 2017

Merged! Thanks @hikouki, sorry for the slow turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants