Fix native range thumb styles on Webkit (Chrome/Safari) #10562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The range slider's thumb was not styling correctly on Chrome or Safari. This was simply because the pseudo-element `::-webkit-slider-thumb` had been incorrectly written as `::-wekit-slider-handle` in `scss/forms/_range.scss`. This revision fixes it to correctly use `::-webkit-slider-thumb`. Test Plan: - Run `npm start` - View `slider.html` in the docs in Chrome and check the range slider's thumb is now styled correctly. - View the docs in Firefox and Edge and ensure they are still correct. - Run `npm run test:sass` and ensure all the tests still pass
|
Awesome, thanks @farrago! This looks good, and congrats on first merged PR! |
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #10553; the range slider's thumb was not styling correctly on Chrome or Safari.
This was simply because the pseudo-element
::-webkit-slider-thumbhad been incorrectly written as
::-wekit-slider-handleinscss/forms/_range.scss.This revision fixes it to correctly use
::-webkit-slider-thumb.Test Plan:
npm startslider.htmlin the docs in Chrome and check the rangeslider's thumb is now styled correctly.
npm run test:sassand ensure all the tests still passReviewers:
@kball - would you be appropriate to review this?