Fix slider data-start float bug #10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamManchanda
approved these changes
Aug 28, 2017
|
@kball This looks cool ( https://www.w3schools.com/jsref/jsref_parsefloat.asp ) |
|
OK, so from what I can tell the reason this shows up with start and not with end is because that '+' turns it into a string concatenation, while if you try to use '-' it will actually transform it to numbers. Innnteresting. Ok, good to go. Thanks for the PR! |
|
glad I could help! |
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IamManchanda per your request
data-start float with a trailing 0 is typed as a string. This causes an undesired concatenation breaking the slider.
#10579