Reveal anchor focus fix #10711
Merged
Reveal anchor focus fix #10711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@IamManchanda Would you like to review this PR or do I merge it ? |
|
Taking this up @ncoden |
| @@ -228,6 +228,9 @@ class Reveal extends Plugin { | |||
| } | |||
| } | |||
|
|
|||
| // Remember anchor that opened it to set focus back later, have general anchors as fallback | |||
| this.$activeAnchor = $(document.activeElement).is(this.$anchor) ? $(document.activeElement) : this.$anchor; | |||
|
I think we should merge it @ncoden |
|
@IamManchanda This PR do not install or update any package. Why updating the yarn lock file there ? |
This reverts commit 6cfebc3.
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…ix for v6.5.0 9fce99e Focus active anchor rather than last one in collection when closing a Reveal modal. 9e8535a Added tests for foundation#10604. f954f7e Added visual test for foundation#10604. 6cfebc3 Update Yarn file! 6bc8691 Revert "Update Yarn file!" Co-Authored-By: Harry Manchanda <harmanmanchanda182@gmail.com> Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus active anchor rather than last one in collection when closing a Reveal modal.
Addresses #10604.