fix: trigger opened.zf.offcanvas at the end to prevent race conditions #10967
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
approved these changes
Feb 21, 2018
| @@ -280,6 +280,7 @@ class OffCanvas extends Plugin { | |||
| * @param {Object} event - Event object passed from listener. | |||
| * @param {jQuery} trigger - element that triggered the off-canvas to open. | |||
| * @fires OffCanvas#opened | |||
| * @todo also trigger 'open' event? | |||
There was a problem hiding this comment.
Right. It's a todo annotation so we don't forget to revisit this (I hope so). =)
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…dless-chrome for v6.5.0 1e789d5 tests: migrate to mocha-headless-chrome 3e86d6e revert GetDimensions() unit test change for IE11 58ca238 fire opened.zf.offcanvas after adding the classes to prevent some race conditions 5c91b76 trigger opened.zf.offcanvas at the end 5744ead reflect change of npm script name in readme 1e1b349 Revert "fire opened.zf.offcanvas after adding the classes to prevent some race conditions" c5ef695 Revert "trigger opened.zf.offcanvas at the end" 12ae1a9 revert component file and test to initial state 2eee404 remove whitespace from empty line 137edac add missing whitespace to empty line 8922cf6 chore: update package-lock for mocha-headless-chrome Co-Authored-By: Daniel Ruf <daniel.ruf@ueberbit.de> Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a race condition and triggers the event after all other things are done.